Commit 909fc8d1 authored by Dragos Tatulea's avatar Dragos Tatulea Committed by Jakub Kicinski
Browse files

net/mlx5e: SHAMPO, Add no-split ethtool counters for header/data split 



When SHAMPO can't identify the protocol/header of a packet, it will
yield a packet that is not split - all the packet is in the data part.
Count this value in packets and bytes.

Signed-off-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20240911201757.1505453-15-saeed@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5bd87709

Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst

+16 −0
Original line number Diff line number Diff line
@@ -218,6 +218,22 @@ the software port. 
       [#accel]_.

     - Informative



   * - `rx[i]_hds_nosplit_packets`

     - Number of packets that were not split in header/data split mode. A

       packet will not get split when the hardware does not support its

       protocol splitting. An example such a protocol is ICMPv4/v6. Currently

       TCP and UDP with IPv4/IPv6 are supported for header/data split

       [#accel]_.

     - Informative



   * - `rx[i]_hds_nosplit_bytes`

     - Number of bytes for packets that were not split in header/data split

       mode. A packet will not get split when the hardware does not support its

       protocol splitting. An example such a protocol is ICMPv4/v6. Currently

       TCP and UDP with IPv4/IPv6 are supported for header/data split

       [#accel]_.

     - Informative



   * - `rx[i]_lro_packets`

     - The number of LRO packets received on ring i [#accel]_.

     - Acceleration

drivers/net/ethernet/mellanox/mlx5/core/en_rx.c

+3 −0
Original line number Diff line number Diff line
@@ -2346,6 +2346,9 @@ static void mlx5e_handle_rx_cqe_mpwrq_shampo(struct mlx5e_rq *rq, struct mlx5_cq 
			stats->hds_nodata_packets++;

			stats->hds_nodata_bytes += head_size;

		}

	} else {

		stats->hds_nosplit_packets++;

		stats->hds_nosplit_bytes += data_bcnt;

	}



	mlx5e_shampo_complete_rx_cqe(rq, cqe, cqe_bcnt, *skb);

drivers/net/ethernet/mellanox/mlx5/core/en_stats.c

+6 −0
Original line number Diff line number Diff line
@@ -144,6 +144,8 @@ static const struct counter_desc sw_stats_desc[] = { 
	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_gro_large_hds) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nodata_packets) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nodata_bytes) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nosplit_packets) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nosplit_bytes) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_ecn_mark) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_removed_vlan_packets) },

	{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_unnecessary) },
@@ -347,6 +349,8 @@ static void mlx5e_stats_grp_sw_update_stats_rq_stats(struct mlx5e_sw_stats *s, 
	s->rx_gro_large_hds           += rq_stats->gro_large_hds;

	s->rx_hds_nodata_packets      += rq_stats->hds_nodata_packets;

	s->rx_hds_nodata_bytes        += rq_stats->hds_nodata_bytes;

	s->rx_hds_nosplit_packets     += rq_stats->hds_nosplit_packets;

	s->rx_hds_nosplit_bytes       += rq_stats->hds_nosplit_bytes;

	s->rx_ecn_mark                += rq_stats->ecn_mark;

	s->rx_removed_vlan_packets    += rq_stats->removed_vlan_packets;

	s->rx_csum_none               += rq_stats->csum_none;
@@ -2062,6 +2066,8 @@ static const struct counter_desc rq_stats_desc[] = { 
	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, gro_large_hds) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nodata_packets) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nodata_bytes) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nosplit_packets) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nosplit_bytes) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, ecn_mark) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, removed_vlan_packets) },

	{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, wqe_err) },

drivers/net/ethernet/mellanox/mlx5/core/en_stats.h

+4 −0
Original line number Diff line number Diff line
@@ -156,6 +156,8 @@ struct mlx5e_sw_stats { 
	u64 rx_gro_large_hds;

	u64 rx_hds_nodata_packets;

	u64 rx_hds_nodata_bytes;

	u64 rx_hds_nosplit_packets;

	u64 rx_hds_nosplit_bytes;

	u64 rx_mcast_packets;

	u64 rx_ecn_mark;

	u64 rx_removed_vlan_packets;
@@ -356,6 +358,8 @@ struct mlx5e_rq_stats { 
	u64 gro_large_hds;

	u64 hds_nodata_packets;

	u64 hds_nodata_bytes;

	u64 hds_nosplit_packets;

	u64 hds_nosplit_bytes;

	u64 mcast_packets;

	u64 ecn_mark;

	u64 removed_vlan_packets;