Commit 90d012fb authored by Li Zhijian's avatar Li Zhijian Committed by Herbert Xu
Browse files

hwrng: core - Convert sprintf/snprintf to sysfs_emit 



Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() will be converted as weel if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

CC: Olivia Mackall <olivia@selenic.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: linux-crypto@vger.kernel.org
Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 355577ef

drivers/char/hw_random/core.c

+1 −1
Original line number Diff line number Diff line
@@ -382,7 +382,7 @@ static ssize_t rng_current_show(struct device *dev, 
	if (IS_ERR(rng))

		return PTR_ERR(rng);



	ret = snprintf(buf, PAGE_SIZE, "%s\n", rng ? rng->name : "none");

	ret = sysfs_emit(buf, "%s\n", rng ? rng->name : "none");

	put_rng(rng);



	return ret;