Commit 90f3c123 authored Jan 06, 2026 by Gal Pressman Committed by Andrew Morton Jan 19, 2026

panic: only warn about deprecated panic_print on write access

The panic_print_deprecated() warning is being triggered on both read and
write operations to the panic_print parameter.

This causes spurious warnings when users run 'sysctl -a' to list all
sysctl values, since that command reads /proc/sys/kernel/panic_print and
triggers the deprecation notice.

Modify the handlers to only emit the deprecation warning when the
parameter is actually being set:

 - sysctl_panic_print_handler(): check 'write' flag before warning.
 - panic_print_get(): remove the deprecation call entirely.

This way, users are only warned when they actively try to use the
deprecated parameter, not when passively querying system state.

Link: https://lkml.kernel.org/r/20260106163321.83586-1-gal@nvidia.com


Fixes: ee13240c ("panic: add note that panic_print sysctl interface is deprecated")
Fixes: 2683df65 ("panic: add note that 'panic_print' parameter is deprecated")
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Reviewed-by: Nimrod Oren <noren@nvidia.com>
Cc: Feng Tang <feng.tang@linux.alibaba.com>
Cc: Joel Granados <joel.granados@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

parent f9a49aa3

kernel/panic.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -131,6 +131,7 @@ static int proc_taint(const struct ctl_table *table, int write,
		static int sysctl_panic_print_handler(const struct ctl_table *table, int write,
		void buffer, size_t lenp, loff_t *ppos)
		{
		if (write)
		panic_print_deprecated();
		return proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
		}
		@@ -1014,7 +1015,6 @@ static int panic_print_set(const char val, const struct kernel_param kp)

		static int panic_print_get(char val, const struct kernel_param kp)
		{
		panic_print_deprecated();
		return param_get_ulong(val, kp);
		}