Commit 90fe70d4 authored by Ilkka Koskinen's avatar Ilkka Koskinen Committed by Namhyung Kim
Browse files

perf vendor events arm64: AmpereOne: Add missing DefaultMetricgroupName fields 



AmpereOne metrics were missing DefaultMetricgroupName from metrics with
"Default" in group name resulting perf to segfault. Add the missing
field to address the issue.

Fixes: 59faeaf8 ("perf vendor events arm64: Fix for AmpereOne metrics")
Signed-off-by: default avatarIlkka Koskinen <ilkka@os.amperecomputing.com>
Reviewed-by: default avatarIan Rogers <irogers@google.com>
Cc: James Clark <james.clark@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20231201021550.1109196-2-ilkka@os.amperecomputing.com


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent e2b005d6

tools/perf/pmu-events/arch/arm64/ampere/ampereone/metrics.json

+2 −0
Original line number Diff line number Diff line
@@ -231,6 +231,7 @@ 
        "MetricName": "slots_lost_misspeculation_fraction",

        "MetricExpr": "100 * ((OP_SPEC - OP_RETIRED) / (CPU_CYCLES * #slots))",

        "BriefDescription": "Fraction of slots lost due to misspeculation",

        "DefaultMetricgroupName": "TopdownL1",

        "MetricGroup": "Default;TopdownL1",

        "ScaleUnit": "1percent of slots"

    },
@@ -238,6 +239,7 @@ 
        "MetricName": "retired_fraction",

        "MetricExpr": "100 * (OP_RETIRED / (CPU_CYCLES * #slots))",

        "BriefDescription": "Fraction of slots retiring, useful work",

        "DefaultMetricgroupName": "TopdownL1",

        "MetricGroup": "Default;TopdownL1",

	"ScaleUnit": "1percent of slots"

    },