Commit 91105ed6 authored by Wei Yongjun's avatar Wei Yongjun Committed by Philipp Zabel
Browse files

reset: mchp: sparx5: fix return value check in mchp_sparx5_map_io() 



In case of error, the function devm_platform_get_and_ioremap_resource()
returns ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: 453ed428 ("reset: mchp: sparx5: add switch reset driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210519141638.3052456-1-weiyongjun1@huawei.com


Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 747aeec9

drivers/reset/reset-microchip-sparx5.c

+2 −2
Original line number Diff line number Diff line
@@ -82,9 +82,9 @@ static int mchp_sparx5_map_io(struct platform_device *pdev, int index, 
	void __iomem *mem;



	mem = devm_platform_get_and_ioremap_resource(pdev, index, &res);

	if (!mem) {

	if (IS_ERR(mem)) {

		dev_err(&pdev->dev, "Could not map resource %d\n", index);

		return -ENXIO;

		return PTR_ERR(mem);

	}

	sparx5_reset_regmap_config.name = res->name;

	map = devm_regmap_init_mmio(&pdev->dev, mem, &sparx5_reset_regmap_config);