Commit 91231571 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Bjorn Helgaas
Browse files

PCI: qcom-ep: Disable resources unconditionally during PERST# assert 

All EP specific resources are enabled during PERST# deassert. As a counter
operation, all resources should be disabled during PERST# assert. There is
no point in skipping that if the link was not enabled.

This will also result in enablement of the resources twice if PERST# got
deasserted again. So remove the check from qcom_pcie_perst_assert() and
disable all the resources unconditionally.

Fixes: f55fee56 ("PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver")
Link: https://lore.kernel.org/linux-pci/20240430-pci-epf-rework-v4-1-22832d0d456f@linaro.org


Tested-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
parent c71b5eb3

drivers/pci/controller/dwc/pcie-qcom-ep.c

+0 −6
Original line number Diff line number Diff line
@@ -521,12 +521,6 @@ static int qcom_pcie_perst_deassert(struct dw_pcie *pci) 
static void qcom_pcie_perst_assert(struct dw_pcie *pci)

{

	struct qcom_pcie_ep *pcie_ep = to_pcie_ep(pci);

	struct device *dev = pci->dev;



	if (pcie_ep->link_status == QCOM_PCIE_EP_LINK_DISABLED) {

		dev_dbg(dev, "Link is already disabled\n");

		return;

	}



	dw_pcie_ep_cleanup(&pci->ep);

	qcom_pcie_disable_resources(pcie_ep);