Commit 91ba8de8 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: scan: Do not mark button ACPI devices as wakeup-capable 



It is generally questionable to mark struct acpi_device "devices" as
wakeup-capable because they represent firmware entities that by
themselves have no wakeup capabilities.

It was done for struct acpi_device "devices" corresponding to buttons
because the ACPI button driver was binding to them directly, but now
that corresponding platform devices are created for the buttons and
they are marked as wakeup-capable by the ACPI button driver, there is
no reason to continue doing it.

Update acpi_wakeup_gpe_init() accordingly.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2891119.BEx9A2HvPv@rafael.j.wysocki
parent 2cf321ef

drivers/acpi/scan.c

+0 −1
Original line number Diff line number Diff line
@@ -1023,7 +1023,6 @@ static bool acpi_wakeup_gpe_init(struct acpi_device *device) 
		    wakeup->sleep_state == ACPI_STATE_S5)

			wakeup->sleep_state = ACPI_STATE_S4;

		acpi_mark_gpe_for_wake(wakeup->gpe_device, wakeup->gpe_number);

		device_set_wakeup_capable(&device->dev, true);

		return true;

	}