Commit 91ded20f authored by Qiuxu Zhuo's avatar Qiuxu Zhuo Committed by Tony Luck
Browse files

EDAC/skx_common: Remove redundant upper bound check for res->imc 



The following upper bound check for the memory controller physical index
decoded by ADXL is the only place where use the macro 'NUM_IMC' is used:

  res->imc > NUM_IMC - 1

Since this check is already covered by skx_get_mc_mapping(), meaning no
memory controller logical index exists for an invalid memory controller
physical index decoded by ADXL, remove the redundant upper bound check
so that the definition for 'NUM_IMC' can be cleaned up (in another patch).

Signed-off-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20250731145534.2759334-6-qiuxu.zhuo@intel.com
parent 43060ca5

drivers/edac/skx_common.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static bool skx_adxl_decode(struct decoded_addr *res, enum error_source err_src) 
		res->cs      = (int)adxl_values[component_indices[INDEX_CS]];

	}



	if (res->imc > NUM_IMC - 1 || res->imc < 0) {

	if (res->imc < 0) {

		skx_printk(KERN_ERR, "Bad imc %d\n", res->imc);

		return false;

	}