Commit 91f950b4 authored by Antoniu Miclaus's avatar Antoniu Miclaus Committed by Jonathan Cameron
Browse files

iio: gyro: mpu3050-i2c: fix pm_runtime error handling 



The return value of pm_runtime_get_sync() is not checked, and the
function always returns success. This allows I2C mux operations to
proceed even when the device fails to resume.

Use pm_runtime_resume_and_get() and propagate its return value to
properly handle resume failures.

Fixes: 3904b28e ("iio: gyro: Add driver for the MPU-3050 gyroscope")
Signed-off-by: default avatarAntoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent dd6183e4

drivers/iio/gyro/mpu3050-i2c.c

+1 −2
Original line number Diff line number Diff line
@@ -19,8 +19,7 @@ static int mpu3050_i2c_bypass_select(struct i2c_mux_core *mux, u32 chan_id) 
	struct mpu3050 *mpu3050 = i2c_mux_priv(mux);



	/* Just power up the device, that is all that is needed */

	pm_runtime_get_sync(mpu3050->dev);

	return 0;

	return pm_runtime_resume_and_get(mpu3050->dev);

}



static int mpu3050_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)