Commit 920aa3a7 authored by Sidharth Seela's avatar Sidharth Seela Committed by Shuah Khan
Browse files

selftests: cachestat: Fix warning on declaration under label 

Fix warning caused from declaration under a case label. The proper way
is to declare variable at the beginning of the function. The warning
came from running clang using LLVM=1; and is as follows:

-test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
  260 |                 char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
      |

Link: https://lore.kernel.org/r/20250929115405.25695-2-sidharthseela@gmail.com


Signed-off-by: default avatarSidharth Seela <sidharthseela@gmail.com>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Reviewed-by: default avatarwang lian <lianux.mm@gmail.com>
Reviewed-by: default avatarDev Jain <dev.jain@arm.com>
Acked-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Acked-by: default avatarNhat Pham <nphamcs@gmail.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent b90cafb4

tools/testing/selftests/cachestat/test_cachestat.c

+2 −2
Original line number Diff line number Diff line
@@ -226,7 +226,7 @@ bool run_cachestat_test(enum file_type type) 
	int syscall_ret;

	size_t compute_len = PS * 512;

	struct cachestat_range cs_range = { PS, compute_len };

	char *filename = "tmpshmcstat";

	char *filename = "tmpshmcstat", *map;

	struct cachestat cs;

	bool ret = true;

	int fd;
@@ -257,7 +257,7 @@ bool run_cachestat_test(enum file_type type) 
		}

		break;

	case FILE_MMAP:

		char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,

		map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,

				 MAP_SHARED, fd, 0);



		if (map == MAP_FAILED) {