Commit 920efe3e authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: net: add more info to error in bpf_offload 



bpf_offload caught a spurious warning in TC recently, but the error
message did not provide enough information to know what the problem
is:

  FAIL: Found 'netdevsim' in command output, leaky extack?

Add the extack to the output:

  FAIL: Unexpected command output, leaky extack? ('netdevsim', 'Warning: Filter with specified priority/protocol not found.')

Acked-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 16a04d04

tools/testing/selftests/net/bpf_offload.py

+3 −2
Original line number Diff line number Diff line
@@ -594,8 +594,9 @@ def check_extack_nsim(output, reference, args): 
    check_extack(output, "netdevsim: " + reference, args)



def check_no_extack(res, needle):

    fail((res[1] + res[2]).count(needle) or (res[1] + res[2]).count("Warning:"),

         "Found '%s' in command output, leaky extack?" % (needle))

    haystack = (res[1] + res[2]).strip()

    fail(haystack.count(needle) or haystack.count("Warning:"),

         "Unexpected command output, leaky extack? ('%s', '%s')" % (needle, haystack))



def check_verifier_log(output, reference):

    lines = output.split("\n")