Commit 923d3104 authored by Dimitri Fedrau's avatar Dimitri Fedrau Committed by Jakub Kicinski
Browse files

net: phy: marvell-88q2xxx: remove duplicated assignment of pma_extable 



Remove assignment of phydev->pma_extable in mv88q222x_revb0_config_init.
It is already done in mv88q2xxx_config_init, just call
mv88q2xxx_config_init.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDimitri Fedrau <dima.fedrau@gmail.com>
Link: https://lore.kernel.org/r/20240218075753.18067-14-dima.fedrau@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ec266094

drivers/net/phy/marvell-88q2xxx.c

+1 −7
Original line number Diff line number Diff line
@@ -701,12 +701,6 @@ static int mv88q222x_revb0_config_init(struct phy_device *phydev) 
			return ret;

	}



	/* The 88Q2XXX PHYs do have the extended ability register available, but

	 * register MDIO_PMA_EXTABLE where they should signalize it does not

	 * work according to specification. Therefore, we force it here.

	 */

	phydev->pma_extable = MDIO_PMA_EXTABLE_BT1;



	/* Configure interrupt with default settings, output is driven low for

	 * active interrupt and high for inactive.

	 */
@@ -715,7 +709,7 @@ static int mv88q222x_revb0_config_init(struct phy_device *phydev) 
					MDIO_MMD_PCS_MV_GPIO_INT_CTRL,

					MDIO_MMD_PCS_MV_GPIO_INT_CTRL_TRI_DIS);



	return 0;

	return mv88q2xxx_config_init(phydev);

}



static int mv88q222x_cable_test_start(struct phy_device *phydev)