Commit 92647580 authored by Vincent Guittot's avatar Vincent Guittot Committed by Peter Zijlstra
Browse files

sched/fair: Update overutilized detection 



Checking uclamp_min is useless and counterproductive for overutilized state
as misfit can now happen without being in overutilized state.

Since commit e5ed0550 ("sched/fair: unlink misfit task from cpu overutilized")
util_fits_cpu returns -1 when uclamp_min is above capacity which is not
considered as cpu overutilized.

Remove the useless rq_util_min parameter.

Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarQais Yousef <qyousef@layalina.io>
Reviewed-by: default avatarChristian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/20260213101751.3121899-1-vincent.guittot@linaro.org
parent db4551e2

kernel/sched/fair.c

+2 −3
Original line number Diff line number Diff line
@@ -7018,16 +7018,15 @@ static inline void hrtick_update(struct rq *rq) 


static inline bool cpu_overutilized(int cpu)

{

	unsigned long  rq_util_min, rq_util_max;

	unsigned long rq_util_max;



	if (!sched_energy_enabled())

		return false;



	rq_util_min = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN);

	rq_util_max = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX);



	/* Return true only if the utilization doesn't fit CPU's capacity */

	return !util_fits_cpu(cpu_util_cfs(cpu), rq_util_min, rq_util_max, cpu);

	return !util_fits_cpu(cpu_util_cfs(cpu), 0, rq_util_max, cpu);

}



/*