Commit 928dbaaa authored by Mukesh Ojha's avatar Mukesh Ojha Committed by Bjorn Andersson
Browse files

soc: qcom: mdtloader: Remove qcom_mdt_pas_init() from exported symbols 



qcom_mdt_pas_init() was previously used only by the remoteproc driver
(drivers/remoteproc/qcom_q6v5_pas.c). Since that driver has now
transitioned to using PAS context-based qcom_mdt_pas_load() function,
making qcom_mdt_pas_init() obsolete for external use.

Removes qcom_mdt_pas_init() from the list of exported symbols and make
it static to limit its scope to internal use within mdtloader.

Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: default avatarMukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260105-kvmrprocv10-v10-7-022e96815380@oss.qualcomm.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 8a4fcffd

drivers/soc/qcom/mdt_loader.c

+5 −17
Original line number Diff line number Diff line
@@ -227,18 +227,7 @@ void *qcom_mdt_read_metadata(const struct firmware *fw, size_t *data_len, 
}

EXPORT_SYMBOL_GPL(qcom_mdt_read_metadata);



/**

 * qcom_mdt_pas_init() - initialize PAS region for firmware loading

 * @dev:	device handle to associate resources with

 * @fw:		firmware object for the mdt file

 * @fw_name:	name of the firmware, for construction of segment file names

 * @pas_id:	PAS identifier

 * @mem_phys:	physical address of allocated memory region

 * @ctx:	PAS context, ctx->metadata to be released by caller

 *

 * Returns 0 on success, negative errno otherwise.

 */

int qcom_mdt_pas_init(struct device *dev, const struct firmware *fw,

static int __qcom_mdt_pas_init(struct device *dev, const struct firmware *fw,

			       const char *fw_name, int pas_id, phys_addr_t mem_phys,

			       struct qcom_scm_pas_context *ctx)

{
@@ -302,7 +291,6 @@ int qcom_mdt_pas_init(struct device *dev, const struct firmware *fw, 
out:

	return ret;

}

EXPORT_SYMBOL_GPL(qcom_mdt_pas_init);



static bool qcom_mdt_bins_are_split(const struct firmware *fw)

{
@@ -469,7 +457,7 @@ int qcom_mdt_load(struct device *dev, const struct firmware *fw, 
{

	int ret;



	ret = qcom_mdt_pas_init(dev, fw, fw_name, pas_id, mem_phys, NULL);

	ret = __qcom_mdt_pas_init(dev, fw, fw_name, pas_id, mem_phys, NULL);

	if (ret)

		return ret;
@@ -500,7 +488,7 @@ int qcom_mdt_pas_load(struct qcom_scm_pas_context *ctx, const struct firmware *f 
{

	int ret;



	ret = qcom_mdt_pas_init(ctx->dev, fw, firmware, ctx->pas_id, ctx->mem_phys, ctx);

	ret = __qcom_mdt_pas_init(ctx->dev, fw, firmware, ctx->pas_id, ctx->mem_phys, ctx);

	if (ret)

		return ret;

include/linux/soc/qcom/mdt_loader.h

+0 −10
Original line number Diff line number Diff line
@@ -15,9 +15,6 @@ struct qcom_scm_pas_context; 
#if IS_ENABLED(CONFIG_QCOM_MDT_LOADER)



ssize_t qcom_mdt_get_size(const struct firmware *fw);

int qcom_mdt_pas_init(struct device *dev, const struct firmware *fw,

		      const char *fw_name, int pas_id, phys_addr_t mem_phys,

		      struct qcom_scm_pas_context *pas_ctx);

int qcom_mdt_load(struct device *dev, const struct firmware *fw,

		  const char *fw_name, int pas_id, void *mem_region,

		  phys_addr_t mem_phys, size_t mem_size,
@@ -40,13 +37,6 @@ static inline ssize_t qcom_mdt_get_size(const struct firmware *fw) 
	return -ENODEV;

}



static inline int qcom_mdt_pas_init(struct device *dev, const struct firmware *fw,

				    const char *fw_name, int pas_id, phys_addr_t mem_phys,

				    struct qcom_scm_pas_context *pas_ctx)

{

	return -ENODEV;

}



static inline int qcom_mdt_load(struct device *dev, const struct firmware *fw,

				const char *fw_name, int pas_id,

				void *mem_region, phys_addr_t mem_phys,