Commit 92909cde authored by hengzhou's avatar hengzhou Committed by Alex Deucher
Browse files

drm/amd/display: Wait DMCUB to idle state before reset. 



[WHY]
Very low rate to cause memory access issue while resetting
DMCUB after the halt command was sent to it.
The process of stopping fw of DMCUB may be timeout, that means
it is not in idle state, such as the window frames may still be
kept in cache, so reset by force will cause MMHUB hang.

[HOW]
After the halt command was sent, keep checking the DMCUB state until
it is idle.

Reviewed-by: default avatarEric Yang <Eric.Yang2@amd.com>
Reviewed-by: default avatarNicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: default avatarJasdeep Dhillon <jdhillon@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarhengzhou <Hengyong.Zhou@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 8440f575

drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ struct dccg { 
	int ref_dppclk;

	//int dtbclk_khz[MAX_PIPES];/* TODO needs to be removed */

	//int audio_dtbclk_khz;/* TODO needs to be removed */

	//int ref_dtbclk_khz;/* TODO needs to be removed */

	int ref_dtbclk_khz;/* TODO needs to be removed */

};



struct dtbclk_dto_params {

drivers/gpu/drm/amd/display/dmub/src/dmub_dcn31.c

+8 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ void dmub_dcn31_reset(struct dmub_srv *dmub) 
{

	union dmub_gpint_data_register cmd;

	const uint32_t timeout = 100;

	uint32_t in_reset, scratch, i;

	uint32_t in_reset, scratch, i, pwait_mode;



	REG_GET(DMCUB_CNTL2, DMCUB_SOFT_RESET, &in_reset);
@@ -115,6 +115,13 @@ void dmub_dcn31_reset(struct dmub_srv *dmub) 
			udelay(1);

		}



		for (i = 0; i < timeout; ++i) {

			REG_GET(DMCUB_CNTL, DMCUB_PWAIT_MODE_STATUS, &pwait_mode);

			if (pwait_mode & (1 << 0))

				break;



			udelay(1);

		}

		/* Force reset in case we timed out, DMCUB is likely hung. */

	}

drivers/gpu/drm/amd/display/dmub/src/dmub_dcn31.h

+2 −1
Original line number Diff line number Diff line
@@ -151,7 +151,8 @@ struct dmub_srv; 
	DMUB_SF(DCN_VM_FB_OFFSET, FB_OFFSET) \

	DMUB_SF(DMCUB_INBOX0_WPTR, DMCUB_INBOX0_WPTR) \

	DMUB_SF(DMCUB_INTERRUPT_ENABLE, DMCUB_GPINT_IH_INT_EN) \

	DMUB_SF(DMCUB_INTERRUPT_ACK, DMCUB_GPINT_IH_INT_ACK)

	DMUB_SF(DMCUB_INTERRUPT_ACK, DMCUB_GPINT_IH_INT_ACK) \

	DMUB_SF(DMCUB_CNTL, DMCUB_PWAIT_MODE_STATUS)



struct dmub_srv_dcn31_reg_offset {

#define DMUB_SR(reg) uint32_t reg;