Commit 92e239e3 authored by Gang Yan's avatar Gang Yan Committed by Jakub Kicinski
Browse files

mptcp: fix address removal logic in mptcp_pm_nl_rm_addr 



Fix inverted WARN_ON_ONCE condition that prevented normal address
removal counter updates. The current code only executes decrement
logic when the counter is already 0 (abnormal state), while
normal removals (counter > 0) are ignored.

Signed-off-by: default avatarGang Yan <yangang@kylinos.cn>
Fixes: 63611391 ("mptcp: pm: remove '_nl' from mptcp_pm_nl_rm_addr_received")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251118-net-mptcp-misc-fixes-6-18-rc6-v1-10-806d3781c95f@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0e4ec14d

net/mptcp/pm_kernel.c

+1 −1
Original line number Diff line number Diff line
@@ -672,7 +672,7 @@ static void mptcp_pm_nl_add_addr_received(struct mptcp_sock *msk) 


void mptcp_pm_nl_rm_addr(struct mptcp_sock *msk, u8 rm_id)

{

	if (rm_id && WARN_ON_ONCE(msk->pm.add_addr_accepted == 0)) {

	if (rm_id && !WARN_ON_ONCE(msk->pm.add_addr_accepted == 0)) {

		u8 limit_add_addr_accepted =

			mptcp_pm_get_limit_add_addr_accepted(msk);