Commit 92f7acb8 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: phy: avoid genphy_c45_ethtool_get_eee() setting eee_enabled 



genphy_c45_ethtool_get_eee() is only called from phy_ethtool_get_eee(),
which then calls eeecfg_to_eee(). eeecfg_to_eee() will overwrite
keee.eee_enabled, so there's no point setting keee.eee_enabled in
genphy_c45_ethtool_get_eee(). Remove this assignment.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/E1tJ9J7-006LIn-Jr@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent bac3d0f2

drivers/net/phy/phy-c45.c

+1 −3
Original line number Diff line number Diff line
@@ -1521,15 +1521,13 @@ EXPORT_SYMBOL(genphy_c45_eee_is_active); 
int genphy_c45_ethtool_get_eee(struct phy_device *phydev,

			       struct ethtool_keee *data)

{

	bool is_enabled;

	int ret;



	ret = genphy_c45_eee_is_active(phydev, data->advertised,

				       data->lp_advertised, &is_enabled);

				       data->lp_advertised, NULL);

	if (ret < 0)

		return ret;



	data->eee_enabled = is_enabled;

	data->eee_active = phydev->eee_active;

	linkmode_copy(data->supported, phydev->supported_eee);