Commit 92fb8986 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: pcs: xpcs: drop interface argument from internal functions 



Now that we no longer use the "interface" argument when creating the
XPCS sub-driver, remove it from xpcs_create() and xpcs_init_iface().

Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1svfMG-005ZI9-3k@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 277b339c

drivers/net/pcs/pcs-xpcs.c

+5 −6
Original line number Diff line number Diff line
@@ -1483,7 +1483,7 @@ static int xpcs_init_id(struct dw_xpcs *xpcs) 
	return 0;

}



static int xpcs_init_iface(struct dw_xpcs *xpcs, phy_interface_t interface)

static int xpcs_init_iface(struct dw_xpcs *xpcs)

{

	if (xpcs->info.pma == WX_TXGBE_XPCS_PMA_10G_ID)

		xpcs->pcs.poll = false;
@@ -1493,8 +1493,7 @@ static int xpcs_init_iface(struct dw_xpcs *xpcs, phy_interface_t interface) 
	return 0;

}



static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev,

				   phy_interface_t interface)

static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev)

{

	struct dw_xpcs *xpcs;

	int ret;
@@ -1511,7 +1510,7 @@ static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev, 
	if (ret)

		goto out_clear_clks;



	ret = xpcs_init_iface(xpcs, interface);

	ret = xpcs_init_iface(xpcs);

	if (ret)

		goto out_clear_clks;
@@ -1546,7 +1545,7 @@ struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr, 
	if (IS_ERR(mdiodev))

		return ERR_CAST(mdiodev);



	xpcs = xpcs_create(mdiodev, interface);

	xpcs = xpcs_create(mdiodev);



	/* xpcs_create() has taken a refcount on the mdiodev if it was

	 * successful. If xpcs_create() fails, this will free the mdio
@@ -1584,7 +1583,7 @@ struct dw_xpcs *xpcs_create_fwnode(struct fwnode_handle *fwnode, 
	if (!mdiodev)

		return ERR_PTR(-EPROBE_DEFER);



	xpcs = xpcs_create(mdiodev, interface);

	xpcs = xpcs_create(mdiodev);



	/* xpcs_create() has taken a refcount on the mdiodev if it was

	 * successful. If xpcs_create() fails, this will free the mdio