Commit 931a765c authored by Youssef Samir's avatar Youssef Samir Committed by Jeff Hugo
Browse files

accel/qaic: Change aic100_image_table definition 



aic100_image_table is currently defined as a "const char *" array,
this can potentially lead to the accidental modification of the
pointers inside. Also, checkpatch.pl gives a warning about it.

Change the type to a "const char * const" array to make the pointers
immutable, preventing accidental modification of the images' paths.

Signed-off-by: default avatarYoussef Samir <quic_yabdulra@quicinc.com>
Reviewed-by: default avatarCarl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: default avatarJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241213185110.2469159-1-quic_jhugo@quicinc.com
parent 713a3418

drivers/accel/qaic/sahara.c

+2 −2
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ struct sahara_context { 
	struct work_struct		fw_work;

	struct work_struct		dump_work;

	struct mhi_device		*mhi_dev;

	const char			**image_table;

	const char * const		*image_table;

	u32				table_size;

	u32				active_image_id;

	const struct firmware		*firmware;
@@ -177,7 +177,7 @@ struct sahara_context { 
	bool				is_mem_dump_mode;

};



static const char *aic100_image_table[] = {

static const char * const aic100_image_table[] = {

	[1]  = "qcom/aic100/fw1.bin",

	[2]  = "qcom/aic100/fw2.bin",

	[4]  = "qcom/aic100/fw4.bin",