Commit 9334003d authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Leon Romanovsky
Browse files

RDMA: Don't use %pK through printk 



In the past %pK was preferable to %p as it would not leak raw pointer
values into the kernel log.
Since commit ad67b74d ("printk: hash addresses printed with %p")
the regular %p has been improved to avoid this issue.
Furthermore, restricted pointers ("%pK") were never meant to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping looks in atomic contexts.

Switch to the regular pointer formatting which is safer and
easier to reason about.

Signed-off-by: default avatarThomas Weißschuh <thomas.weissschuh@linutronix.de>
Link: https://patch.msgid.link/20250407-restricted-pointers-infiniband-v1-1-22b20504b84d@linutronix.de


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent b84001ad

drivers/infiniband/hw/irdma/ctrl.c

+1 −1
Original line number Diff line number Diff line
@@ -3131,7 +3131,7 @@ int irdma_sc_cqp_init(struct irdma_sc_cqp *cqp, 
	writel(0, cqp->dev->hw_regs[IRDMA_CCQPSTATUS]);



	ibdev_dbg(to_ibdev(cqp->dev),

		  "WQE: sq_size[%04d] hw_sq_size[%04d] sq_base[%p] sq_pa[%pK] cqp[%p] polarity[x%04x]\n",

		  "WQE: sq_size[%04d] hw_sq_size[%04d] sq_base[%p] sq_pa[%p] cqp[%p] polarity[x%04x]\n",

		  cqp->sq_size, cqp->hw_sq_size, cqp->sq_base,

		  (u64 *)(uintptr_t)cqp->sq_pa, cqp, cqp->polarity);

	return 0;

drivers/infiniband/hw/irdma/pble.c

+1 −1
Original line number Diff line number Diff line
@@ -108,7 +108,7 @@ static int add_sd_direct(struct irdma_hmc_pble_rsrc *pble_rsrc, 
	chunk->vaddr = sd_entry->u.bp.addr.va + offset;

	chunk->fpm_addr = pble_rsrc->next_fpm_addr;

	ibdev_dbg(to_ibdev(dev),

		  "PBLE: chunk_size[%lld] = 0x%llx vaddr=0x%pK fpm_addr = %llx\n",

		  "PBLE: chunk_size[%lld] = 0x%llx vaddr=0x%p fpm_addr = %llx\n",

		  chunk->size, chunk->size, chunk->vaddr, chunk->fpm_addr);



	return 0;

drivers/infiniband/hw/usnic/usnic_uiom.c

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ static int usnic_uiom_dma_fault(struct iommu_domain *domain, 
				unsigned long iova, int flags,

				void *token)

{

	usnic_err("Device %s iommu fault domain 0x%pK va 0x%lx flags 0x%x\n",

	usnic_err("Device %s iommu fault domain 0x%p va 0x%lx flags 0x%x\n",

		dev_name(dev),

		domain, iova, flags);

	return -ENOSYS;

drivers/infiniband/sw/siw/siw.h

+1 −1
Original line number Diff line number Diff line
@@ -738,7 +738,7 @@ static inline void siw_crc_skb(struct siw_rx_stream *srx, unsigned int len) 
		  "MEM[0x%08x] %s: " fmt, mem->stag, __func__, ##__VA_ARGS__)



#define siw_dbg_cep(cep, fmt, ...)                                             \

	ibdev_dbg(&cep->sdev->base_dev, "CEP[0x%pK] %s: " fmt,                 \

	ibdev_dbg(&cep->sdev->base_dev, "CEP[0x%p] %s: " fmt,                 \

		  cep, __func__, ##__VA_ARGS__)



void siw_cq_flush(struct siw_cq *cq);

drivers/infiniband/sw/siw/siw_cq.c

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ int siw_reap_cqe(struct siw_cq *cq, struct ib_wc *wc) 
			wc->opcode = map_wc_opcode[cqe->opcode];

			wc->status = map_cqe_status[cqe->status].ib;

			siw_dbg_cq(cq,

				   "idx %u, type %d, flags %2x, id 0x%pK\n",

				   "idx %u, type %d, flags %2x, id 0x%p\n",

				   cq->cq_get % cq->num_cqe, cqe->opcode,

				   cqe->flags, (void *)(uintptr_t)cqe->id);

		} else {