Commit 93387385 authored by Avri Altman's avatar Avri Altman Committed by Ulf Hansson
Browse files

mmc: core: Don't use close-ended rw for SDUC 



The SDUC spec expects CMD22 to get squeezed between CMD23 and the
read/write command, e.g. CMD23->CMD22->CMD18 and CMD23->CMD22->CMD25.
At this early stage of adoption, we want to avoid an amid stream of
fixes & quirks of bogus hw, that tends to apply extra logic specifically
around auto-cmd12 & auto-cmd23.

Let's leave close-ended out for now, and re-consider this should those
cards become ubiquitous, if any.

It also means that BLK_FEAT_FUA will not be used for I/O, but instead we
will rely on BLK_FEAT_WRITE_CACHE.

Reviewed-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Signed-off-by: default avatarAvri Altman <avri.altman@wdc.com>
Link: https://lore.kernel.org/r/20241006051148.160278-4-avri.altman@wdc.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 375b5359

drivers/mmc/core/block.c

+1 −1
Original line number Diff line number Diff line
@@ -2547,7 +2547,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card, 
	if (mmc_host_cmd23(card->host)) {

		if ((mmc_card_mmc(card) &&

		     card->csd.mmca_vsn >= CSD_SPEC_VER_3) ||

		    (mmc_card_sd(card) &&

		    (mmc_card_sd(card) && !mmc_card_ult_capacity(card) &&

		     card->scr.cmds & SD_SCR_CMD23_SUPPORT))

			md->flags |= MMC_BLK_CMD23;

	}