Commit 9351bbb1 authored by Vasileios Amoiridis's avatar Vasileios Amoiridis Committed by Jonathan Cameron
Browse files

iio: core: mark scan_timestamp as __private 



Since there are no more direct accesses to the indio_dev->scan_timestamp
value, it can be marked as __private and use the macro ACCESS_PRIVATE()
in order to access it. Like this, static checkers will be able to inform
in case someone tries to either write to the value, or read its value
directly.

Signed-off-by: default avatarVasileios Amoiridis <vassilisamir@gmail.com>
Link: https://patch.msgid.link/20241214191421.94172-5-vassilisamir@gmail.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 6d0981f9

drivers/iio/industrialio-buffer.c

+1 −1
Original line number Diff line number Diff line
@@ -1137,7 +1137,7 @@ static int iio_enable_buffers(struct iio_dev *indio_dev, 
	int ret;



	indio_dev->active_scan_mask = config->scan_mask;

	indio_dev->scan_timestamp = config->scan_timestamp;

	ACCESS_PRIVATE(indio_dev, scan_timestamp) = config->scan_timestamp;

	indio_dev->scan_bytes = config->scan_bytes;

	iio_dev_opaque->currentmode = config->mode;

include/linux/iio/buffer.h

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ int iio_pop_from_buffer(struct iio_buffer *buffer, void *data); 
static inline int iio_push_to_buffers_with_timestamp(struct iio_dev *indio_dev,

	void *data, int64_t timestamp)

{

	if (indio_dev->scan_timestamp) {

	if (ACCESS_PRIVATE(indio_dev, scan_timestamp)) {

		size_t ts_offset = indio_dev->scan_bytes / sizeof(int64_t) - 1;

		((int64_t *)data)[ts_offset] = timestamp;

	}

include/linux/iio/iio.h

+1 −1
Original line number Diff line number Diff line
@@ -611,7 +611,7 @@ struct iio_dev { 
	const unsigned long		*available_scan_masks;

	unsigned int			__private masklength;

	const unsigned long		*active_scan_mask;

	bool				scan_timestamp;

	bool				__private scan_timestamp;

	struct iio_trigger		*trig;

	struct iio_poll_func		*pollfunc;

	struct iio_poll_func		*pollfunc_event;