Commit 93614c2a authored by Simona Vetter's avatar Simona Vetter Committed by Jeff Hugo
Browse files

accel/qaic: delete qaic_bo.handle 



Handles are per-file, not global, so this makes no sense. Plus it's
set only after calling drm_gem_handle_create(), and drivers are not
allowed to further initialize a bo after that function has published it
already.

It is also entirely unused, which helps enormously with removing it
:-)

Since we're still holding a reference to the bo nothing bad can
happen, hence not cc: stable material.

Cc: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Cc: Carl Vanderlip <quic_carlv@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: default avatarSimona Vetter <simona.vetter@ffwll.ch>
Signed-off-by: default avatarSimona Vetter <simona.vetter@intel.com>
Reviewed-by: default avatarJeff Hugo <jeff.hugo@oss.qualcomm.com>
Signed-off-by: default avatarJeff Hugo <jeff.hugo@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250528091307.1894940-5-simona.vetter@ffwll.ch
parent d3b88721

drivers/accel/qaic/qaic.h

+0 −2
Original line number Diff line number Diff line
@@ -221,8 +221,6 @@ struct qaic_bo { 
	bool			sliced;

	/* Request ID of this BO if it is queued for execution */

	u16			req_id;

	/* Handle assigned to this BO */

	u32			handle;

	/* Wait on this for completion of DMA transfer of this BO */

	struct completion	xfer_done;

	/*

drivers/accel/qaic/qaic_data.c

+0 −1
Original line number Diff line number Diff line
@@ -731,7 +731,6 @@ int qaic_create_bo_ioctl(struct drm_device *dev, void *data, struct drm_file *fi 
	if (ret)

		goto free_bo;



	bo->handle = args->handle;

	drm_gem_object_put(obj);

	srcu_read_unlock(&qdev->dev_lock, qdev_rcu_id);

	srcu_read_unlock(&usr->qddev_lock, usr_rcu_id);