Commit 93893a57 authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Jakub Kicinski
Browse files

net: s/dev_get_flags/netif_get_flags/ 



Commit cc34acd5 ("docs: net: document new locking reality")
introduced netif_ vs dev_ function semantics: the former expects locked
netdev, the latter takes care of the locking. We don't strictly
follow this semantics on either side, but there are more dev_xxx handlers
now that don't fit. Rename them to netif_xxx where appropriate.

Signed-off-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250717172333.1288349-6-sdf@fomichev.me


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 303a8487

drivers/infiniband/sw/rxe/rxe_verbs.c

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ static int rxe_query_port(struct ib_device *ibdev, 
	attr->state = ib_get_curr_port_state(ndev);

	if (attr->state == IB_PORT_ACTIVE)

		attr->phys_state = IB_PORT_PHYS_STATE_LINK_UP;

	else if (dev_get_flags(ndev) & IFF_UP)

	else if (netif_get_flags(ndev) & IFF_UP)

		attr->phys_state = IB_PORT_PHYS_STATE_POLLING;

	else

		attr->phys_state = IB_PORT_PHYS_STATE_DISABLED;

fs/smb/server/smb2pdu.c

+1 −1
Original line number Diff line number Diff line
@@ -7847,7 +7847,7 @@ static int fsctl_query_iface_info_ioctl(struct ksmbd_conn *conn, 
		if (!ksmbd_find_netdev_name_iface_list(netdev->name))

			continue;



		flags = dev_get_flags(netdev);

		flags = netif_get_flags(netdev);

		if (!(flags & IFF_RUNNING))

			continue;

ipv6_retry:

include/linux/netdevice.h

+1 −1
Original line number Diff line number Diff line
@@ -4196,7 +4196,7 @@ int generic_hwtstamp_set_lower(struct net_device *dev, 
			       struct kernel_hwtstamp_config *kernel_cfg,

			       struct netlink_ext_ack *extack);

int dev_ethtool(struct net *net, struct ifreq *ifr, void __user *userdata);

unsigned int dev_get_flags(const struct net_device *);

unsigned int netif_get_flags(const struct net_device *dev);

int __dev_change_flags(struct net_device *dev, unsigned int flags,

		       struct netlink_ext_ack *extack);

int netif_change_flags(struct net_device *dev, unsigned int flags,

net/8021q/vlan.c

+1 −1
Original line number Diff line number Diff line
@@ -483,7 +483,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event, 
	case NETDEV_UP:

		/* Put all VLANs for this dev in the up state too.  */

		vlan_group_for_each_dev(grp, i, vlandev) {

			flgs = dev_get_flags(vlandev);

			flgs = netif_get_flags(vlandev);

			if (flgs & IFF_UP)

				continue;

net/bridge/br_netlink.c

+1 −1
Original line number Diff line number Diff line
@@ -479,7 +479,7 @@ static int br_fill_ifinfo(struct sk_buff *skb, 
	hdr->__ifi_pad = 0;

	hdr->ifi_type = dev->type;

	hdr->ifi_index = dev->ifindex;

	hdr->ifi_flags = dev_get_flags(dev);

	hdr->ifi_flags = netif_get_flags(dev);

	hdr->ifi_change = 0;



	if (nla_put_string(skb, IFLA_IFNAME, dev->name) ||