Commit 93985110 authored by Baojun Xu's avatar Baojun Xu Committed by Takashi Iwai
Browse files

ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device 



In the SPI driver probe, the chip ID must be set to TAS2781. Without this
initialization, calibration data fails to load correctly, causing audio
abnormalities on some devices.
And update the register bulk read API to handle the distinct requirements
of SPI and I2C devices.

Fixes: 05ac3846 ("ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781")
Signed-off-by: default avatarBaojun Xu <baojun.xu@ti.com>
Link: https://patch.msgid.link/20260418055030.765-1-baojun.xu@ti.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 8a7be65e

sound/hda/codecs/side-codecs/tas2781_hda_spi.c

+1 −0
Original line number Diff line number Diff line
@@ -788,6 +788,7 @@ static int tas2781_hda_spi_probe(struct spi_device *spi) 
	}

	if (strstr(dev_name(&spi->dev), "TXNW2781")) {

		device_name = "TXNW2781";

		tas_hda->priv->chip_id = TAS2781;

	} else {

		dev_err(tas_priv->dev, "Unmatched spi dev %s\n",

			dev_name(&spi->dev));

sound/soc/codecs/tas2781-fmwlib.c

+3 −4
Original line number Diff line number Diff line
@@ -2487,7 +2487,7 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i) 
		if (spec == NULL)

			return -ENOMEM;

		priv->tasdevice[i].cali_specific = spec;

		rc = tasdevice_dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);

		rc = priv->dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);

		if (rc < 0) {

			dev_err(priv->dev, "invalid RE from %d = %d\n", i, rc);

			return rc;
@@ -2511,8 +2511,7 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i) 
				TASDEVICE_REG(0, 0x1b, 0x34) :

				TASDEVICE_REG(0, 0x18, 0x1c);



			rc = tasdevice_dev_bulk_read(priv, i,

						      spec->sin_gni_reg,

			rc = priv->dev_bulk_read(priv, i, spec->sin_gni_reg,

						 spec->sin_gni, 4);

			if (rc < 0) {

				dev_err(priv->dev, "wrong sinegaini %d = %d\n",