Commit 93a08f85 authored by Baihan Li's avatar Baihan Li Committed by Dmitry Baryshkov
Browse files

drm/hisilicon/hibmc: fix the hibmc loaded failed bug 



When hibmc loaded failed, the driver use hibmc_unload to free the
resource, but the mutexes in mode.config are not init, which will
access an NULL pointer. Just change goto statement to return, because
hibnc_hw_init() doesn't need to free anything.

Fixes: b3df5e65 ("drm/hibmc: Drop drm_vblank_cleanup")
Signed-off-by: default avatarBaihan Li <libaihan@huawei.com>
Signed-off-by: default avatarYongbang Shi <shiyongbang@huawei.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250813094238.3722345-5-shiyongbang@huawei.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 8bed4ec4

drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -319,13 +319,13 @@ static int hibmc_load(struct drm_device *dev) 


	ret = hibmc_hw_init(priv);

	if (ret)

		goto err;

		return ret;



	ret = drmm_vram_helper_init(dev, pci_resource_start(pdev, 0),

				    pci_resource_len(pdev, 0));

	if (ret) {

		drm_err(dev, "Error initializing VRAM MM; %d\n", ret);

		goto err;

		return ret;

	}



	ret = hibmc_kms_init(priv);