Unverified Commit 940dd88c authored by James Flowers's avatar James Flowers Committed by Javier Martinez Canillas
Browse files

drm/ssd130x: Use kmalloc_array() instead of kmalloc() 



Documentation/process/deprecated.rst recommends against the use of
kmalloc with dynamic size calculations due to the risk of overflow and
smaller allocation being made than the caller was expecting.
kmalloc_array avoids this issue.

Signed-off-by: default avatarJames Flowers <bold.zone2373@fastmail.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20250914073841.69582-1-bold.zone2373@fastmail.com


Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
parent 4db6e24f

drivers/gpu/drm/solomon/ssd130x.c

+3 −3
Original line number Diff line number Diff line
@@ -1498,7 +1498,7 @@ static int ssd130x_crtc_atomic_check(struct drm_crtc *crtc, 
	if (ret)

		return ret;



	ssd130x_state->data_array = kmalloc(ssd130x->width * pages, GFP_KERNEL);

	ssd130x_state->data_array = kmalloc_array(ssd130x->width, pages, GFP_KERNEL);

	if (!ssd130x_state->data_array)

		return -ENOMEM;
@@ -1519,7 +1519,7 @@ static int ssd132x_crtc_atomic_check(struct drm_crtc *crtc, 
	if (ret)

		return ret;



	ssd130x_state->data_array = kmalloc(columns * ssd130x->height, GFP_KERNEL);

	ssd130x_state->data_array = kmalloc_array(columns, ssd130x->height, GFP_KERNEL);

	if (!ssd130x_state->data_array)

		return -ENOMEM;
@@ -1546,7 +1546,7 @@ static int ssd133x_crtc_atomic_check(struct drm_crtc *crtc, 


	pitch = drm_format_info_min_pitch(fi, 0, ssd130x->width);



	ssd130x_state->data_array = kmalloc(pitch * ssd130x->height, GFP_KERNEL);

	ssd130x_state->data_array = kmalloc_array(pitch, ssd130x->height, GFP_KERNEL);

	if (!ssd130x_state->data_array)

		return -ENOMEM;