Unverified Commit 942ac8da authored by Michal Wajdeczko's avatar Michal Wajdeczko Committed by Rodrigo Vivi
Browse files

drm/xe/configfs: Fix pci_dev reference leak 



We are using pci_get_domain_bus_and_slot() function to verify if
the given config directory name matches any existing PCI device,
but we missed to call matching pci_dev_put() to release reference.

While around, also change error code in case of no device match,
to make it more specific than generic formatting error.

Fixes: 16280ded ("drm/xe: Add configfs to enable survivability mode")
Signed-off-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
Link: https://lore.kernel.org/r/20250722141059.30707-2-michal.wajdeczko@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit 0bdd05c2)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 4846856c

drivers/gpu/drm/xe/xe_configfs.c

+2 −1
Original line number Diff line number Diff line
@@ -267,7 +267,8 @@ static struct config_group *xe_config_make_device_group(struct config_group *gro 


	pdev = pci_get_domain_bus_and_slot(domain, bus, PCI_DEVFN(slot, function));

	if (!pdev)

		return ERR_PTR(-EINVAL);

		return ERR_PTR(-ENODEV);

	pci_dev_put(pdev);



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)