Commit 9443c19c authored by Quentin Schulz's avatar Quentin Schulz Committed by Jonathan Cameron
Browse files

iio: adc: rockchip_saradc: replace custom logic with devm_reset_control_get_optional_exclusive 



devm_reset_control_get_optional_exclusive does what this driver is
trying to do in its probe function, therefore let's switch over to that
subsystem function.

Signed-off-by: default avatarQuentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240223-saradcv2-chan-mask-v1-3-84b06a0f623a@theobroma-systems.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 5b4e4b72

drivers/iio/adc/rockchip_saradc.c

+3 −8
Original line number Diff line number Diff line
@@ -450,16 +450,11 @@ static int rockchip_saradc_probe(struct platform_device *pdev) 
	 * The reset should be an optional property, as it should work

	 * with old devicetrees as well

	 */

	info->reset = devm_reset_control_get_exclusive(&pdev->dev,

	info->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,

								"saradc-apb");

	if (IS_ERR(info->reset)) {

		ret = PTR_ERR(info->reset);

		if (ret != -ENOENT)

			return dev_err_probe(&pdev->dev, ret,

					     "failed to get saradc-apb\n");



		dev_dbg(&pdev->dev, "no reset control found\n");

		info->reset = NULL;

		return dev_err_probe(&pdev->dev, ret, "failed to get saradc-apb\n");

	}



	init_completion(&info->completion);