Commit 944edca8 authored by Tzung-Bi Shih's avatar Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_ishtp: Fix UAF after unbinding driver 

After unbinding the driver, another kthread `cros_ec_console_log_work`
is still accessing the device, resulting an UAF and crash.

The driver doesn't unregister the EC device in .remove() which should
shutdown sub-devices synchronously.  Fix it.

Fixes: 26a14267 ("platform/chrome: Add ChromeOS EC ISHTP driver")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20251031033900.3577394-1-tzungbi@kernel.org


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent c862381b

drivers/platform/chrome/cros_ec_ishtp.c

+1 −0
Original line number Diff line number Diff line
@@ -667,6 +667,7 @@ static void cros_ec_ishtp_remove(struct ishtp_cl_device *cl_device) 


	cancel_work_sync(&client_data->work_ishtp_reset);

	cancel_work_sync(&client_data->work_ec_evt);

	cros_ec_unregister(client_data->ec_dev);

	cros_ish_deinit(cros_ish_cl);

	ishtp_put_device(cl_device);

}