Commit 9452252d authored by Dan Carpenter's avatar Dan Carpenter Committed by Bartosz Golaszewski
Browse files

gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in probe() 



The devm_platform_ioremap_resource() function doesn't return NULL, it
returns error pointers.  Fix the checking to match.

Fixes: e8850024 ("gpio: add QIXIS FPGA GPIO controller")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarMichael Walle <mwalle@kernel.org>
Link: https://lore.kernel.org/r/aPsaaf0h343Ba7c1@stanley.mountain


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 96fbc805

drivers/gpio/gpio-qixis-fpga.c

+2 −2
Original line number Diff line number Diff line
@@ -56,8 +56,8 @@ static int qixis_cpld_gpio_probe(struct platform_device *pdev) 
		 * create our own from the MMIO space.

		 */

		reg = devm_platform_ioremap_resource(pdev, 0);

		if (!reg)

			return -ENODEV;

		if (IS_ERR(reg))

			return PTR_ERR(reg);



		regmap = devm_regmap_init_mmio(&pdev->dev, reg, &regmap_config_8r_8v);

		if (!regmap)