Unverified Commit 9462e74c authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Ilpo Järvinen
Browse files

platform/x86: ISST: Correct command storage data length 



After resume/online turbo limit ratio (TRL) is restored partially if
the admin explicitly changed TRL from user space.

A hash table is used to store SST mail box and MSR settings when modified
to restore those settings after resume or online. This uses a struct
isst_cmd field "data" to store these settings. This is a 64 bit field.
But isst_store_new_cmd() is only assigning as u32. This results in
truncation of 32 bits.

Change the argument to u64 from u32.

Fixes: f607874f ("platform/x86: ISST: Restore state on resume")
Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250328224749.2691272-1-srinivas.pandruvada@linux.intel.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 2b9f84e7

drivers/platform/x86/intel/speed_select_if/isst_if_common.c

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ static DECLARE_HASHTABLE(isst_hash, 8); 
static DEFINE_MUTEX(isst_hash_lock);



static int isst_store_new_cmd(int cmd, u32 cpu, int mbox_cmd_type, u32 param,

			      u32 data)

			      u64 data)

{

	struct isst_cmd *sst_cmd;