Commit 94a20fb9 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

sysfs: treewide: constify attribute callback of bin_attribute::mmap() 



The mmap() callbacks should not modify the struct
bin_attribute passed as argument.
Enforce this by marking the argument as const.

As there are not many callback implementers perform this change
throughout the tree at once.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com> # ocxl
Acked-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Link: https://lore.kernel.org/r/20241103-sysfs-const-bin_attr-v2-6-71110628844c@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b626816f

arch/alpha/kernel/pci-sysfs.c

+3 −3
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num, 
 * Return: %0 on success, negative error code otherwise

 */

static int pci_mmap_resource(struct kobject *kobj,

			     struct bin_attribute *attr,

			     const struct bin_attribute *attr,

			     struct vm_area_struct *vma, int sparse)

{

	struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));
@@ -93,14 +93,14 @@ static int pci_mmap_resource(struct kobject *kobj, 
}



static int pci_mmap_resource_sparse(struct file *filp, struct kobject *kobj,

				    struct bin_attribute *attr,

				    const struct bin_attribute *attr,

				    struct vm_area_struct *vma)

{

	return pci_mmap_resource(kobj, attr, vma, 1);

}



static int pci_mmap_resource_dense(struct file *filp, struct kobject *kobj,

				   struct bin_attribute *attr,

				   const struct bin_attribute *attr,

				   struct vm_area_struct *vma)

{

	return pci_mmap_resource(kobj, attr, vma, 0);

drivers/misc/ocxl/sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ static const struct vm_operations_struct global_mmio_vmops = { 
};



static int global_mmio_mmap(struct file *filp, struct kobject *kobj,

			struct bin_attribute *bin_attr,

			const struct bin_attribute *bin_attr,

			struct vm_area_struct *vma)

{

	struct ocxl_afu *afu = to_afu(kobj_to_dev(kobj));

drivers/pci/p2pdma.c

+1 −1
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ static ssize_t published_show(struct device *dev, struct device_attribute *attr, 
static DEVICE_ATTR_RO(published);



static int p2pmem_alloc_mmap(struct file *filp, struct kobject *kobj,

		struct bin_attribute *attr, struct vm_area_struct *vma)

		const struct bin_attribute *attr, struct vm_area_struct *vma)

{

	struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));

	size_t len = vma->vm_end - vma->vm_start;

drivers/pci/pci-sysfs.c

+5 −5
Original line number Diff line number Diff line
@@ -910,7 +910,7 @@ static ssize_t pci_write_legacy_io(struct file *filp, struct kobject *kobj, 
 * memory space.

 */

static int pci_mmap_legacy_mem(struct file *filp, struct kobject *kobj,

			       struct bin_attribute *attr,

			       const struct bin_attribute *attr,

			       struct vm_area_struct *vma)

{

	struct pci_bus *bus = to_pci_bus(kobj_to_dev(kobj));
@@ -930,7 +930,7 @@ static int pci_mmap_legacy_mem(struct file *filp, struct kobject *kobj, 
 * memory space. Returns -ENOSYS if the operation isn't supported

 */

static int pci_mmap_legacy_io(struct file *filp, struct kobject *kobj,

			      struct bin_attribute *attr,

			      const struct bin_attribute *attr,

			      struct vm_area_struct *vma)

{

	struct pci_bus *bus = to_pci_bus(kobj_to_dev(kobj));
@@ -1034,7 +1034,7 @@ void pci_remove_legacy_files(struct pci_bus *b) 
 *

 * Use the regular PCI mapping routines to map a PCI resource into userspace.

 */

static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr,

static int pci_mmap_resource(struct kobject *kobj, const struct bin_attribute *attr,

			     struct vm_area_struct *vma, int write_combine)

{

	struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));
@@ -1059,14 +1059,14 @@ static int pci_mmap_resource(struct kobject *kobj, struct bin_attribute *attr, 
}



static int pci_mmap_resource_uc(struct file *filp, struct kobject *kobj,

				struct bin_attribute *attr,

				const struct bin_attribute *attr,

				struct vm_area_struct *vma)

{

	return pci_mmap_resource(kobj, attr, vma, 0);

}



static int pci_mmap_resource_wc(struct file *filp, struct kobject *kobj,

				struct bin_attribute *attr,

				const struct bin_attribute *attr,

				struct vm_area_struct *vma)

{

	return pci_mmap_resource(kobj, attr, vma, 1);

drivers/platform/x86/intel/pmt/class.c

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ intel_pmt_read(struct file *filp, struct kobject *kobj, 


static int

intel_pmt_mmap(struct file *filp, struct kobject *kobj,

		struct bin_attribute *attr, struct vm_area_struct *vma)

		const struct bin_attribute *attr, struct vm_area_struct *vma)

{

	struct intel_pmt_entry *entry = container_of(attr,

						     struct intel_pmt_entry,