Commit 94b58540 authored by Michal Wajdeczko's avatar Michal Wajdeczko
Browse files

drm/xe/guc: Drop redundant logs about invalid G2H length 



We are now logging details of the failed G2H message (including
its length) at the GuC CT component. Drop now redundant log from
the GuC submit code.

Signed-off-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241105173032.1947-3-michal.wajdeczko@intel.com
parent c4ed1bb1

drivers/gpu/drm/xe/xe_guc_submit.c

+6 −22
Original line number Diff line number Diff line
@@ -1882,15 +1882,12 @@ static void handle_sched_done(struct xe_guc *guc, struct xe_exec_queue *q, 


int xe_guc_sched_done_handler(struct xe_guc *guc, u32 *msg, u32 len)

{

	struct xe_device *xe = guc_to_xe(guc);

	struct xe_exec_queue *q;

	u32 guc_id = msg[0];

	u32 runnable_state = msg[1];



	if (unlikely(len < 2)) {

		drm_err(&xe->drm, "Invalid length %u", len);

	if (unlikely(len < 2))

		return -EPROTO;

	}



	q = g2h_exec_queue_lookup(guc, guc_id);

	if (unlikely(!q))
@@ -1924,14 +1921,11 @@ static void handle_deregister_done(struct xe_guc *guc, struct xe_exec_queue *q) 


int xe_guc_deregister_done_handler(struct xe_guc *guc, u32 *msg, u32 len)

{

	struct xe_device *xe = guc_to_xe(guc);

	struct xe_exec_queue *q;

	u32 guc_id = msg[0];



	if (unlikely(len < 1)) {

		drm_err(&xe->drm, "Invalid length %u", len);

	if (unlikely(len < 1))

		return -EPROTO;

	}



	q = g2h_exec_queue_lookup(guc, guc_id);

	if (unlikely(!q))
@@ -1953,14 +1947,11 @@ int xe_guc_deregister_done_handler(struct xe_guc *guc, u32 *msg, u32 len) 
int xe_guc_exec_queue_reset_handler(struct xe_guc *guc, u32 *msg, u32 len)

{

	struct xe_gt *gt = guc_to_gt(guc);

	struct xe_device *xe = guc_to_xe(guc);

	struct xe_exec_queue *q;

	u32 guc_id = msg[0];



	if (unlikely(len < 1)) {

		drm_err(&xe->drm, "Invalid length %u", len);

	if (unlikely(len < 1))

		return -EPROTO;

	}



	q = g2h_exec_queue_lookup(guc, guc_id);

	if (unlikely(!q))
@@ -2000,10 +1991,8 @@ int xe_guc_error_capture_handler(struct xe_guc *guc, u32 *msg, u32 len) 
{

	u32 status;



	if (unlikely(len != XE_GUC_ACTION_STATE_CAPTURE_NOTIFICATION_DATA_LEN)) {

		xe_gt_dbg(guc_to_gt(guc), "Invalid length %u", len);

	if (unlikely(len != XE_GUC_ACTION_STATE_CAPTURE_NOTIFICATION_DATA_LEN))

		return -EPROTO;

	}



	status = msg[0] & XE_GUC_STATE_CAPTURE_EVENT_STATUS_MASK;

	if (status == XE_GUC_STATE_CAPTURE_EVENT_STATUS_NOSPACE)
@@ -2018,14 +2007,11 @@ int xe_guc_exec_queue_memory_cat_error_handler(struct xe_guc *guc, u32 *msg, 
					       u32 len)

{

	struct xe_gt *gt = guc_to_gt(guc);

	struct xe_device *xe = guc_to_xe(guc);

	struct xe_exec_queue *q;

	u32 guc_id = msg[0];



	if (unlikely(len < 1)) {

		drm_err(&xe->drm, "Invalid length %u", len);

	if (unlikely(len < 1))

		return -EPROTO;

	}



	q = g2h_exec_queue_lookup(guc, guc_id);

	if (unlikely(!q))
@@ -2050,10 +2036,8 @@ int xe_guc_exec_queue_reset_failure_handler(struct xe_guc *guc, u32 *msg, u32 le 
	u8 guc_class, instance;

	u32 reason;



	if (unlikely(len != 3)) {

		drm_err(&xe->drm, "Invalid length %u", len);

	if (unlikely(len != 3))

		return -EPROTO;

	}



	guc_class = msg[0];

	instance = msg[1];