Commit 94d41547 authored by Richard Genoud's avatar Richard Genoud Committed by Alexandre Belloni
Browse files

rtc: tps6594: Fix memleak in probe 



struct rtc_device is allocated twice in probe(), once with
devm_kzalloc(), and then with devm_rtc_allocate_device().

The allocation with devm_kzalloc() is lost and superfluous.

Fixes: 9f67c1e6 ("rtc: tps6594: Add driver for TPS6594 RTC")
Signed-off-by: default avatarRichard Genoud <richard.genoud@bootlin.com>
Link: https://lore.kernel.org/r/20240618141851.1810000-2-richard.genoud@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 1613e604

drivers/rtc/rtc-tps6594.c

+0 −4
Original line number Diff line number Diff line
@@ -360,10 +360,6 @@ static int tps6594_rtc_probe(struct platform_device *pdev) 
	int irq;

	int ret;



	rtc = devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL);

	if (!rtc)

		return -ENOMEM;



	rtc = devm_rtc_allocate_device(dev);

	if (IS_ERR(rtc))

		return PTR_ERR(rtc);