Commit 94fdd55b authored by Marijn Suijten's avatar Marijn Suijten Committed by Dmitry Baryshkov
Browse files

drm/msm/dpu: Drop unused members from HW structs 



Some of these members were initialized while never read, while others
were not even assigned any pointer value at all.  Drop them to save some
space, and above all confusion when looking at or accidentally
dereferencing these members.

Signed-off-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/533862/
Link: https://lore.kernel.org/r/20230418-dpu-drop-useless-for-lookup-v3-2-e8d869eea455@somainline.org


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 10036161

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c

+0 −1
Original line number Diff line number Diff line
@@ -359,7 +359,6 @@ struct dpu_hw_intf *dpu_hw_intf_init(enum dpu_intf idx, 
	 */

	c->idx = idx;

	c->cap = cfg;

	c->mdss = m;

	_setup_intf_ops(&c->ops, c->cap->features);



	return c;

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h

+0 −1
Original line number Diff line number Diff line
@@ -90,7 +90,6 @@ struct dpu_hw_intf { 
	/* intf */

	enum dpu_intf idx;

	const struct dpu_intf_cfg *cap;

	const struct dpu_mdss_cfg *mdss;



	/* ops */

	struct dpu_hw_intf_ops ops;

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c

+0 −1
Original line number Diff line number Diff line
@@ -812,7 +812,6 @@ struct dpu_hw_sspp *dpu_hw_sspp_init(enum dpu_sspp idx, 
	}



	/* Assign ops */

	hw_pipe->catalog = catalog;

	hw_pipe->ubwc = catalog->ubwc;

	hw_pipe->idx = idx;

	hw_pipe->cap = cfg;

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h

+0 −2
Original line number Diff line number Diff line
@@ -341,7 +341,6 @@ struct dpu_hw_sspp_ops { 
 * struct dpu_hw_sspp - pipe description

 * @base: hardware block base structure

 * @hw: block hardware details

 * @catalog: back pointer to catalog

 * @ubwc: ubwc configuration data

 * @idx: pipe index

 * @cap: pointer to layer_cfg
@@ -350,7 +349,6 @@ struct dpu_hw_sspp_ops { 
struct dpu_hw_sspp {

	struct dpu_hw_blk base;

	struct dpu_hw_blk_reg_map hw;

	const struct dpu_mdss_cfg *catalog;

	const struct dpu_ubwc_cfg *ubwc;



	/* Pipe */

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c

+0 −1
Original line number Diff line number Diff line
@@ -263,7 +263,6 @@ struct dpu_hw_wb *dpu_hw_wb_init(enum dpu_wb idx, 
	}



	/* Assign ops */

	c->mdp = &m->mdp[0];

	c->idx = idx;

	c->caps = cfg;

	_setup_wb_ops(&c->ops, c->caps->features);