Commit 952e9057 authored by Marco Crivellari's avatar Marco Crivellari Committed by Dave Jiang
Browse files

cxl/pci: replace use of system_wq with system_percpu_wq 



Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

system_wq should be the per-cpu workqueue, yet in this name nothing makes
that clear, so replace system_wq with system_percpu_wq.

The old wq (system_wq) will be kept for a few release cycles.

See 128ea9f6 ("workqueue: Add system_percpu_wq and system_dfl_wq")
for cause of changes.

[ dj: Add reference to commit that initiated the change. ]

Suggested-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarMarco Crivellari <marco.crivellari@suse.com>
Acked-by: default avatarDavidlohr Bueso <dave@stgolabs.net>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>> ---
Link: https://patch.msgid.link/20251030163839.307752-1-marco.crivellari@suse.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 040acb49

drivers/cxl/pci.c

+1 −1
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ static irqreturn_t cxl_pci_mbox_irq(int irq, void *id) 
	if (opcode == CXL_MBOX_OP_SANITIZE) {

		mutex_lock(&cxl_mbox->mbox_mutex);

		if (mds->security.sanitize_node)

			mod_delayed_work(system_wq, &mds->security.poll_dwork, 0);

			mod_delayed_work(system_percpu_wq, &mds->security.poll_dwork, 0);

		mutex_unlock(&cxl_mbox->mbox_mutex);

	} else {

		/* short-circuit the wait in __cxl_pci_mbox_send_cmd() */