Commit 952f9a5f authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Saeed Mahameed
Browse files

net/mlx5: DR, Use swap() instead of open coding it 



Swap is a function interface that provides exchange function. To avoid
code duplication, we can use swap function.

./drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1254:50-51: WARNING opportunity for swap().

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7580


Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 9bb1ac80

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c

+2 −6
Original line number Diff line number Diff line
@@ -1170,7 +1170,6 @@ mlx5dr_action_create_mult_dest_tbl(struct mlx5dr_domain *dmn, 
				   bool ignore_flow_level,

				   u32 flow_source)

{

	struct mlx5dr_cmd_flow_destination_hw_info tmp_hw_dest;

	struct mlx5dr_cmd_flow_destination_hw_info *hw_dests;

	struct mlx5dr_action **ref_actions;

	struct mlx5dr_action *action;
@@ -1249,11 +1248,8 @@ mlx5dr_action_create_mult_dest_tbl(struct mlx5dr_domain *dmn, 
	 * one that done in the TX.

	 * So, if one of the ft target is wire, put it at the end of the dest list.

	 */

	if (is_ft_wire && num_dst_ft > 1) {

		tmp_hw_dest = hw_dests[last_dest];

		hw_dests[last_dest] = hw_dests[num_of_dests - 1];

		hw_dests[num_of_dests - 1] = tmp_hw_dest;

	}

	if (is_ft_wire && num_dst_ft > 1)

		swap(hw_dests[last_dest], hw_dests[num_of_dests - 1]);



	action = dr_action_create_generic(DR_ACTION_TYP_FT);

	if (!action)