Commit 9588e7fc authored by Steve Sistare's avatar Steve Sistare Committed by Michael S. Tsirkin
Browse files

vdpa_sim: reset must not run 



vdpasim_do_reset sets running to true, which is wrong, as it allows
vdpasim_kick_vq to post work requests before the device has been
configured.  To fix, do not set running until VIRTIO_CONFIG_S_DRIVER_OK
is set.

Fixes: 0c89e2a3 ("vdpa_sim: Implement suspend vdpa op")
Signed-off-by: default avatarSteve Sistare <steven.sistare@oracle.com>
Reviewed-by: default avatarEugenio Pérez <eperezma@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Message-Id: <1707517807-137331-1-git-send-email-steven.sistare@oracle.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent ec6ecb84

drivers/vdpa/vdpa_sim/vdpa_sim.c

+2 −1
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ static void vdpasim_do_reset(struct vdpasim *vdpasim, u32 flags) 
		}

	}



	vdpasim->running = true;

	vdpasim->running = false;

	spin_unlock(&vdpasim->iommu_lock);



	vdpasim->features = 0;
@@ -483,6 +483,7 @@ static void vdpasim_set_status(struct vdpa_device *vdpa, u8 status) 


	mutex_lock(&vdpasim->mutex);

	vdpasim->status = status;

	vdpasim->running = (status & VIRTIO_CONFIG_S_DRIVER_OK) != 0;

	mutex_unlock(&vdpasim->mutex);

}