Commit 9590d32e authored by Brett Creeley's avatar Brett Creeley Committed by Jakub Kicinski
Browse files

ionic: Fix netdev notifier unregister on failure 



If register_netdev() fails, then the driver leaks the netdev notifier.
Fix this by calling ionic_lif_unregister() on register_netdev()
failure. This will also call ionic_lif_unregister_phc() if it has
already been registered.

Fixes: 30b87ab4 ("ionic: remove lif list concept")
Signed-off-by: default avatarBrett Creeley <brett.creeley@amd.com>
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20241212213157.12212-2-shannon.nelson@amd.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 663ad748

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+2 −2
Original line number Diff line number Diff line
@@ -3869,8 +3869,8 @@ int ionic_lif_register(struct ionic_lif *lif) 
	/* only register LIF0 for now */

	err = register_netdev(lif->netdev);

	if (err) {

		dev_err(lif->ionic->dev, "Cannot register net device, aborting\n");

		ionic_lif_unregister_phc(lif);

		dev_err(lif->ionic->dev, "Cannot register net device: %d, aborting\n", err);

		ionic_lif_unregister(lif);

		return err;

	}