Commit 95993dc3 authored Jul 20, 2025 by Yonghong Song Committed by Martin KaFai Lau Jul 21, 2025

bpf: Use ERR_CAST instead of ERR_PTR(PTR_ERR(...))



Intel linux test robot reported a warning that ERR_CAST can be used
for error pointer casting instead of more-complicated/rarely-used
ERR_PTR(PTR_ERR(...)) style.

There is no functionality change, but still let us replace two such
instances as it improves consistency and readability.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507201048.bceHy8zX-lkp@intel.com/


Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://patch.msgid.link/20250720164754.3999140-1-yonghong.song@linux.dev

parent 42be23e8

kernel/bpf/cgroup.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -707,11 +707,11 @@ static struct bpf_prog_list get_prog_list(struct hlist_head progs, struct bpf_
		if (is_link) {
		anchor_link = bpf_get_anchor_link(flags, id_or_fd);
		if (IS_ERR(anchor_link))
		return ERR_PTR(PTR_ERR(anchor_link));
		return ERR_CAST(anchor_link);
		} else if (is_id \|\| id_or_fd) {
		anchor_prog = bpf_get_anchor_prog(flags, id_or_fd);
		if (IS_ERR(anchor_prog))
		return ERR_PTR(PTR_ERR(anchor_prog));
		return ERR_CAST(anchor_prog);
		}

		if (!anchor_prog && !anchor_link) {