Unverified Commit 95c5f431 authored by Christian Brauner's avatar Christian Brauner
Browse files

coredump: fix error handling for replace_fd() 

The replace_fd() helper returns the file descriptor number on success
and a negative error code on failure. The current error handling in
umh_pipe_setup() only works because the file descriptor that is replaced
is zero but that's pretty volatile. Explicitly check for a negative
error code.

Link: https://lore.kernel.org/20250414-work-coredump-v2-2-685bf231f828@kernel.org


Tested-by: default avatarLuca Boccassi <luca.boccassi@gmail.com>
Reviewed-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent c57f07b2

fs/coredump.c

+7 −2
Original line number Diff line number Diff line
@@ -507,7 +507,9 @@ static int umh_pipe_setup(struct subprocess_info *info, struct cred *new) 
{

	struct file *files[2];

	struct coredump_params *cp = (struct coredump_params *)info->data;

	int err = create_pipe_files(files, 0);

	int err;



	err = create_pipe_files(files, 0);

	if (err)

		return err;
@@ -515,10 +517,13 @@ static int umh_pipe_setup(struct subprocess_info *info, struct cred *new) 


	err = replace_fd(0, files[0], 0);

	fput(files[0]);

	if (err < 0)

		return err;



	/* and disallow core files too */

	current->signal->rlim[RLIMIT_CORE] = (struct rlimit){1, 1};



	return err;

	return 0;

}



void do_coredump(const kernel_siginfo_t *siginfo)