Commit 95cfe232 authored by Jianbo Liu's avatar Jianbo Liu Committed by Steffen Klassert
Browse files

xfrm: Skip redundant statistics update for crypto offload 



In the crypto offload path, every packet is still processed by the
software stack. The state's statistics required for the expiration
check are being updated in software.

However, the code also calls xfrm_dev_state_update_stats(), which
triggers a query to the hardware device to fetch statistics. This
hardware query is redundant and introduces unnecessary performance
overhead.

Skip this call when it's crypto offload (not packet offload) to avoid
the unnecessary hardware access, thereby improving performance.

Signed-off-by: default avatarJianbo Liu <jianbol@nvidia.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent 94f39804

net/xfrm/xfrm_state.c

+6 −1
Original line number Diff line number Diff line
@@ -2282,6 +2282,11 @@ EXPORT_SYMBOL(xfrm_state_update); 


int xfrm_state_check_expire(struct xfrm_state *x)

{

	/* All counters which are needed to decide if state is expired

	 * are handled by SW for non-packet offload modes. Simply skip

	 * the following update and save extra boilerplate in drivers.

	 */

	if (x->xso.type == XFRM_DEV_OFFLOAD_PACKET)

		xfrm_dev_state_update_stats(x);



	if (!READ_ONCE(x->curlft.use_time))