Commit 95d9c3f0 authored by Siddharth Vadapalli's avatar Siddharth Vadapalli Committed by Bjorn Helgaas
Browse files

PCI: keystone: Exit ks_pcie_probe() for invalid mode 



Commit under Fixes introduced support for PCIe EP mode on AM654x platforms.
When the mode happens to be either "DW_PCIE_RC_TYPE" or "DW_PCIE_EP_TYPE",
the PCIe Controller is configured accordingly. However, when the mode is
neither of them, an error message is displayed, but the driver probe
succeeds. Since this "invalid" mode is not associated with a functional
PCIe Controller, the probe should fail.

Fix the behavior by exiting "ks_pcie_probe()" with the return value of
"-EINVAL" in addition to displaying the existing error message when the
mode is invalid.

Fixes: 23284ad6 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms")
Signed-off-by: default avatarSiddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20251029080547.1253757-4-s-vadapalli@ti.com
parent 3a866087

drivers/pci/controller/dwc/pci-keystone.c

+2 −0
Original line number Diff line number Diff line
@@ -1337,6 +1337,8 @@ static int ks_pcie_probe(struct platform_device *pdev) 
		break;

	default:

		dev_err(dev, "INVALID device type %d\n", mode);

		ret = -EINVAL;

		goto err_get_sync;

	}



	ks_pcie_enable_error_irq(ks_pcie);