Commit 95e467b8 authored by Daniel Machon's avatar Daniel Machon Committed by Jakub Kicinski
Browse files

net: sparx5: verify RGMII speeds 



When doing a port config, we verify the port speed against the PHY mode
and supported speeds of that PHY mode. Add checks for the four RGMII phy
modes: RGMII, RGMII_ID, RGMII_TXID and RGMII_RXID.

Reviewed-by: default avatarSteen Hegelund <Steen.Hegelund@microchip.com>
Reviewed-by: default avatarHoratiu Vultur <horatiu.vultur@microchip.com>
Tested-by: default avatarRobert Marko <robert.marko@sartura.hr>
Signed-off-by: default avatarDaniel Machon <daniel.machon@microchip.com>
Link: https://patch.msgid.link/20241220-sparx5-lan969x-switch-driver-4-v5-6-fa8ba5dff732@microchip.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9b8d70ec

drivers/net/ethernet/microchip/sparx5/sparx5_port.c

+9 −0
Original line number Diff line number Diff line
@@ -257,6 +257,15 @@ static int sparx5_port_verify_speed(struct sparx5 *sparx5, 
		     conf->speed != SPEED_25000))

			return sparx5_port_error(port, conf, SPX5_PERR_SPEED);

		break;

	case PHY_INTERFACE_MODE_RGMII:

	case PHY_INTERFACE_MODE_RGMII_ID:

	case PHY_INTERFACE_MODE_RGMII_TXID:

	case PHY_INTERFACE_MODE_RGMII_RXID:

		if (conf->speed != SPEED_1000 &&

		    conf->speed != SPEED_100 &&

		    conf->speed != SPEED_10)

			return sparx5_port_error(port, conf, SPX5_PERR_SPEED);

		break;

	default:

		return sparx5_port_error(port, conf, SPX5_PERR_IFTYPE);

	}