Commit 96232247 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Handle backpointers with unknown data types 



New data types might be added later, so we don't want to disallow
unknown data types - that'll be a compatibility hassle later. Instead,
ignore them.

Reported-by: default avatar <syzbot+3a290f5ff67ca3023834@syzkaller.appspotmail.com>
Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent 6a9f681e

fs/bcachefs/backpointers.c

+7 −3
Original line number Diff line number Diff line
@@ -784,7 +784,7 @@ enum alloc_sector_counter { 
	ALLOC_SECTORS_NR

};



static enum alloc_sector_counter data_type_to_alloc_counter(enum bch_data_type t)

static int data_type_to_alloc_counter(enum bch_data_type t)

{

	switch (t) {

	case BCH_DATA_btree:
@@ -796,7 +796,7 @@ static enum alloc_sector_counter data_type_to_alloc_counter(enum bch_data_type t 
	case BCH_DATA_parity:

		return ALLOC_stripe;

	default:

		BUG();

		return -1;

	}

}
@@ -847,7 +847,11 @@ static int check_bucket_backpointer_mismatch(struct btree_trans *trans, struct b 
		if (bp.v->bucket_gen != a->gen)

			continue;



		sectors[data_type_to_alloc_counter(bp.v->data_type)] += bp.v->bucket_len;

		int alloc_counter = data_type_to_alloc_counter(bp.v->data_type);

		if (alloc_counter < 0)

			continue;



		sectors[alloc_counter] += bp.v->bucket_len;

	};

	bch2_trans_iter_exit(trans, &iter);

	if (ret)