Commit 96319dac authored by Huang Xiaojia's avatar Huang Xiaojia Committed by Mike Marshall
Browse files

orangefs: Constify struct kobj_type 



'struct kobj_type' is not modified. It is only used in kobject_init()
which takes a 'const struct kobj_type *ktype' parameter.

Constifying this structure moves some data to a read-only section,
so increase over all security.

On a x86_64, compiled with defconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
   7036	   2136	     56	   9228	   240c	fs/orangefs/orangefs-sysfs.o

After:
======
   text	   data	    bss	    dec	    hex	filename
   7484	   1880	     56	   9420	   24cc	fs/orangefs/orangefs-sysfs.o

Signed-off-by: default avatarHuang Xiaojia <huangxiaojia2@huawei.com>
Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent 5be63fc1

fs/orangefs/orangefs-sysfs.c

+7 −7
Original line number Diff line number Diff line
@@ -904,7 +904,7 @@ static void orangefs_obj_release(struct kobject *kobj) 
	orangefs_obj = NULL;

}



static struct kobj_type orangefs_ktype = {

static const struct kobj_type orangefs_ktype = {

	.sysfs_ops = &orangefs_sysfs_ops,

	.default_groups = orangefs_default_groups,

	.release = orangefs_obj_release,
@@ -951,7 +951,7 @@ static void acache_orangefs_obj_release(struct kobject *kobj) 
	acache_orangefs_obj = NULL;

}



static struct kobj_type acache_orangefs_ktype = {

static const struct kobj_type acache_orangefs_ktype = {

	.sysfs_ops = &orangefs_sysfs_ops,

	.default_groups = acache_orangefs_default_groups,

	.release = acache_orangefs_obj_release,
@@ -998,7 +998,7 @@ static void capcache_orangefs_obj_release(struct kobject *kobj) 
	capcache_orangefs_obj = NULL;

}



static struct kobj_type capcache_orangefs_ktype = {

static const struct kobj_type capcache_orangefs_ktype = {

	.sysfs_ops = &orangefs_sysfs_ops,

	.default_groups = capcache_orangefs_default_groups,

	.release = capcache_orangefs_obj_release,
@@ -1045,7 +1045,7 @@ static void ccache_orangefs_obj_release(struct kobject *kobj) 
	ccache_orangefs_obj = NULL;

}



static struct kobj_type ccache_orangefs_ktype = {

static const struct kobj_type ccache_orangefs_ktype = {

	.sysfs_ops = &orangefs_sysfs_ops,

	.default_groups = ccache_orangefs_default_groups,

	.release = ccache_orangefs_obj_release,
@@ -1092,7 +1092,7 @@ static void ncache_orangefs_obj_release(struct kobject *kobj) 
	ncache_orangefs_obj = NULL;

}



static struct kobj_type ncache_orangefs_ktype = {

static const struct kobj_type ncache_orangefs_ktype = {

	.sysfs_ops = &orangefs_sysfs_ops,

	.default_groups = ncache_orangefs_default_groups,

	.release = ncache_orangefs_obj_release,
@@ -1132,7 +1132,7 @@ static void pc_orangefs_obj_release(struct kobject *kobj) 
	pc_orangefs_obj = NULL;

}



static struct kobj_type pc_orangefs_ktype = {

static const struct kobj_type pc_orangefs_ktype = {

	.sysfs_ops = &orangefs_sysfs_ops,

	.default_groups = pc_orangefs_default_groups,

	.release = pc_orangefs_obj_release,
@@ -1165,7 +1165,7 @@ static void stats_orangefs_obj_release(struct kobject *kobj) 
	stats_orangefs_obj = NULL;

}



static struct kobj_type stats_orangefs_ktype = {

static const struct kobj_type stats_orangefs_ktype = {

	.sysfs_ops = &orangefs_sysfs_ops,

	.default_groups = stats_orangefs_default_groups,

	.release = stats_orangefs_obj_release,