Commit 9635c586 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal: intel: x86_pkg_temp_thermal: Handle invalid temperature 



After commit be0a3600 ("thermal: sysfs: Rework the handling of trip
point updates"), THERMAL_TEMP_INVALID can be passed to sys_set_trip_temp()
and it is treated as a regular temperature value there, so the sysfs
write fails even though it is expected to succeed and disable the given
trip point.

Address this by making sys_set_trip_temp() clear its temp variable when
it is equal to THERMAL_TEMP_INVALID.

Fixes: be0a3600 ("thermal: sysfs: Rework the handling of trip point updates")
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2815400.mvXUDI8C0e@rafael.j.wysocki
parent 75faabf6

drivers/thermal/intel/x86_pkg_temp_thermal.c

+3 −0
Original line number Diff line number Diff line
@@ -128,6 +128,9 @@ sys_set_trip_temp(struct thermal_zone_device *tzd, 
	u32 l, h, mask, shift, intr;

	int tj_max, val, ret;



	if (temp == THERMAL_TEMP_INVALID)

		temp = 0;



	tj_max = intel_tcc_get_tjmax(zonedev->cpu);

	if (tj_max < 0)

		return tj_max;