Commit 967969cf authored by Ma Ke's avatar Ma Ke Committed by Vinod Koul
Browse files

phy: cadence-torrent: Check return value on register read 



cdns_torrent_dp_set_power_state() does not consider that ret might be
overwritten. Add return value check of regmap_read_poll_timeout() after
register read in cdns_torrent_dp_set_power_state().

Fixes: 5b16a790 ("phy: cadence-torrent: Reorder few functions to remove function declarations")
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20240702032042.3993031-1-make24@iscas.ac.cn


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent db4eb418

drivers/phy/cadence/phy-cadence-torrent.c

+3 −0
Original line number Diff line number Diff line
@@ -1157,6 +1157,9 @@ static int cdns_torrent_dp_set_power_state(struct cdns_torrent_phy *cdns_phy, 
	ret = regmap_read_poll_timeout(regmap, PHY_PMA_XCVR_POWER_STATE_ACK,

				       read_val, (read_val & mask) == value, 0,

				       POLL_TIMEOUT_US);

	if (ret)

		return ret;



	cdns_torrent_dp_write(regmap, PHY_PMA_XCVR_POWER_STATE_REQ, 0x00000000);

	ndelay(100);