Commit 9697f5ef authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

USB: wdm: handle IO errors in wdm_wwan_port_start 



In case submitting the URB fails we must undo
what we've done so far.

Fixes: cac6fb01 ("usb: class: cdc-wdm: WWAN framework integration")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Link: https://lore.kernel.org/r/20250401084749.175246-2-oneukum@suse.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e00b39a4

drivers/usb/class/cdc-wdm.c

+10 −1
Original line number Diff line number Diff line
@@ -829,6 +829,7 @@ static struct usb_class_driver wdm_class = { 
static int wdm_wwan_port_start(struct wwan_port *port)

{

	struct wdm_device *desc = wwan_port_get_drvdata(port);

	int rv;



	/* The interface is both exposed via the WWAN framework and as a

	 * legacy usbmisc chardev. If chardev is already open, just fail
@@ -848,7 +849,15 @@ static int wdm_wwan_port_start(struct wwan_port *port) 
	wwan_port_txon(port);



	/* Start getting events */

	return usb_submit_urb(desc->validity, GFP_KERNEL);

	rv = usb_submit_urb(desc->validity, GFP_KERNEL);

	if (rv < 0) {

		wwan_port_txoff(port);

		desc->manage_power(desc->intf, 0);

		/* this must be last lest we race with chardev open */

		clear_bit(WDM_WWAN_IN_USE, &desc->flags);

	}



	return rv;

}



static void wdm_wwan_port_stop(struct wwan_port *port)